From 5562d75e3a46437f08cea6fe13aafb1603ab32c3 Mon Sep 17 00:00:00 2001
From: SoXX <soxx@anthrove.art>
Date: Tue, 13 Aug 2024 14:44:27 +0200
Subject: [PATCH] feat(error): more error handling

added missing checks
---
 pkg/database/tagAlias.go | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/pkg/database/tagAlias.go b/pkg/database/tagAlias.go
index f7cfc74..4cf7338 100644
--- a/pkg/database/tagAlias.go
+++ b/pkg/database/tagAlias.go
@@ -32,6 +32,14 @@ func CreateTagAlias(ctx context.Context, tagAliasName models.TagAliasName, tagNa
 		return models.TagAlias{}, utils.HandleError(ctx, span, localLogger, &otterError.Database{Reason: otterError.DatabaseIsNotConnected})
 	}
 
+	if tagAliasName == "" {
+		return models.TagAlias{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.TagAliasNameIsEmpty})
+	}
+
+	if tagName == "" {
+		return models.TagAlias{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.TagNameIsEmpty})
+	}
+
 	tagAlias := models.TagAlias{
 		Name:  tagAliasName,
 		TagID: tagName,
@@ -109,6 +117,10 @@ func DeleteTagAlias(ctx context.Context, tagAliasName models.TagAliasName) error
 		return utils.HandleError(ctx, span, localLogger, &otterError.Database{Reason: otterError.DatabaseIsNotConnected})
 	}
 
+	if len(tagAliasName) == 0 {
+		return utils.HandleError(ctx, span, localLogger, &otterError.Database{Reason: otterError.TagAliasNameIsEmpty})
+	}
+
 	result := client.WithContext(ctx).Delete(&tagAlias, tagAliasName)
 	if result.Error != nil {
 		if errors.Is(result.Error, gorm.ErrRecordNotFound) {