From 92ef2c50596b6829daada3addc4e8354c595c882 Mon Sep 17 00:00:00 2001
From: SoXX <soxx@anthrove.art>
Date: Tue, 13 Aug 2024 15:08:10 +0200
Subject: [PATCH] feat(error): more error handling

added missing checks
---
 pkg/database/tag.go | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/pkg/database/tag.go b/pkg/database/tag.go
index cdb7a14..5e21837 100644
--- a/pkg/database/tag.go
+++ b/pkg/database/tag.go
@@ -32,6 +32,14 @@ func CreateTag(ctx context.Context, tagName models.TagName, tagType models.TagTy
 		return models.Tag{}, utils.HandleError(ctx, span, localLogger, &otterError.Database{Reason: otterError.DatabaseIsNotConnected})
 	}
 
+	if tagName == "" {
+		return models.Tag{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.TagNameIsEmpty})
+	}
+
+	if tagType == "" {
+		return models.Tag{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.TagTypeIsEmpty})
+	}
+
 	tag := models.Tag{
 		Name: tagName,
 		Type: tagType,
@@ -109,6 +117,10 @@ func DeleteTag(ctx context.Context, tagName models.TagName) error {
 		return utils.HandleError(ctx, span, localLogger, &otterError.Database{Reason: otterError.DatabaseIsNotConnected})
 	}
 
+	if len(tagName) == 0 {
+		return utils.HandleError(ctx, span, localLogger, &otterError.Database{Reason: otterError.TagAliasNameIsEmpty})
+	}
+
 	result := client.WithContext(ctx).Delete(&tag, tagName)
 	if result.Error != nil {
 		if errors.Is(result.Error, gorm.ErrRecordNotFound) {