Anthrove/otter-space-sdk
5
0
Fork 0
Code Issues Pull Requests Actions Projects Releases 9 Activity

added pools #14

Merged
SoXX merged 16 commits from dev/pools into main 2024-10-15 09:03:46 +00:00
Conversation 0 Commits 16 Files Changed 20 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 37487c4f52 - Show all commits

4
pkg/database/pool_reference.go
View File

@ -40,7 +40,7 @@ func CreatePoolReference(ctx context.Context, poolID models.PoolID, sourceID mod
return models.PoolReference{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PoolIDIsWrongLength}) return models.PoolReference{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PoolIDIsWrongLength})
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-10-15 08:33:48 +00:00
Outdated
Review
Copy Link

its not really to short, is just had a wrong length....

its not really to short, is just had a wrong length....
} }
if sourceID == "" { if len(sourceID) == 0 {
return models.PoolReference{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.SourceIDIsEmpty}) return models.PoolReference{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.SourceIDIsEmpty})
Alphyron marked this conversation as resolved
Alphyron commented 2024-10-15 08:33:40 +00:00
Review
Copy Link

Either you use len(sourceID) == 0 like in pool.go or you use this method in pool.go. But not both!

Either you use len(sourceID) == 0 like in pool.go or you use this method in pool.go. But not both!
} }
@ -100,7 +100,7 @@ func DeletePoolReference(ctx context.Context, poolID models.PoolID, sourceID mod
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PostIDIsWrongLength}) return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PostIDIsWrongLength})
Alphyron commented 2024-10-15 08:34:27 +00:00
Outdated
Review
Copy Link

its not really to short, is just had a wrong length....

its not really to short, is just had a wrong length....
Alphyron commented 2024-10-15 08:49:56 +00:00
Outdated
Review
Copy Link

Please recheck this, you want to check if the length nis not 25!

Please recheck this, you want to check if the length nis not 25!
} }
if sourceID == "" { if len(sourceID) == 0 {
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.SourceIDIsEmpty}) return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.SourceIDIsEmpty})
Alphyron marked this conversation as resolved
Alphyron commented 2024-10-15 08:33:34 +00:00
Review
Copy Link

Either you use len(sourceID) == 0 like in pool.go or you use this method in pool.go. But not both!

Either you use len(sourceID) == 0 like in pool.go or you use this method in pool.go. But not both!
} }