Anthrove/otter-space-sdk
5
0
Fork 0
Code Issues Pull Requests Actions Projects Releases 9 Activity

added pools #14

Merged
SoXX merged 16 commits from dev/pools into main 2024-10-15 09:03:46 +00:00
Conversation 0 Commits 16 Files Changed 20 +29 -29
8 changed files with 29 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 91254adfe3 - Show all commits

2
pkg/database/favorite.go
View File

@ -183,7 +183,7 @@ func DeleteUserFavorite(ctx context.Context, id models.UserFavoriteID) error {
}
if len(id) != 25 {
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.UserFavoriteIDToShort})
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.UserFavoriteIsWrongLength})
}
result := client.WithContext(ctx).Delete(&userFavorite, id)

2
pkg/database/pool.go
View File

@ -147,7 +147,7 @@ func DeletePool(ctx context.Context, id models.PoolID) error {
}
if len(id) != 25 {
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PoolIDToShort})
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PoolIDIsWrongLength})
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-10-15 08:31:53 +00:00
Outdated
Review
Copy Link

its not really to short, is just had a wrong length....

its not really to short, is just had a wrong length....
}
result := client.WithContext(ctx).Delete(&pool, "id = ?", id)

8
pkg/database/pool_post.go
View File

@ -37,7 +37,7 @@ func CreatePoolPost(ctx context.Context, poolID models.PoolID, postID models.Pos
}
if len(poolID) != 25 {
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-10-15 08:55:42 +00:00
Outdated
Review
Copy Link

Please recheck this, you want to check if the length nis not 25!

Please recheck this, you want to check if the length nis not 25!
return models.PoolPost{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PoolIDToShort})
return models.PoolPost{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PoolIDIsWrongLength})
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-10-15 08:31:36 +00:00
Outdated
Review
Copy Link

its not really to short, is just had a wrong length....

its not really to short, is just had a wrong length....
Alphyron commented 2024-10-15 08:48:49 +00:00
Outdated
Review
Copy Link

Please recheck this, you want to check if the length nis not 25!

Please recheck this, you want to check if the length nis not 25!
}
if postID == "" {
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-10-15 08:30:55 +00:00
Outdated
Review
Copy Link

Either you use len(postID) == 0 like in pool.go or you use this method in pool.go. But not both!

Either you use len(postID) == 0 like in pool.go or you use this method in pool.go. But not both!
@ -45,7 +45,7 @@ func CreatePoolPost(ctx context.Context, poolID models.PoolID, postID models.Pos
}
if len(postID) != 25 {
return models.PoolPost{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PostIDToShort})
return models.PoolPost{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PostIDIsWrongLength})
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-10-15 08:31:43 +00:00
Outdated
Review
Copy Link

its not really to short, is just had a wrong length....

its not really to short, is just had a wrong length....
}
poolPost := models.PoolPost{
@ -93,7 +93,7 @@ func DeletePoolPost(ctx context.Context, poolID models.PoolID, postID models.Pos
}
if len(poolID) != 25 {
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-10-15 08:55:48 +00:00
Outdated
Review
Copy Link

Please recheck this, you want to check if the length nis not 25!

Please recheck this, you want to check if the length nis not 25!
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PoolIDToShort})
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PoolIDIsWrongLength})
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-10-15 08:32:17 +00:00
Outdated
Review
Copy Link

its not really to short, is just had a wrong length....

its not really to short, is just had a wrong length....
Alphyron commented 2024-10-15 08:49:07 +00:00
Outdated
Review
Copy Link

Please recheck this, you want to check if the length nis not 25!

Please recheck this, you want to check if the length nis not 25!
}
if postID == "" {
@ -101,7 +101,7 @@ func DeletePoolPost(ctx context.Context, poolID models.PoolID, postID models.Pos
}
if len(postID) != 25 {
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PostIDToShort})
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PostIDIsWrongLength})
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-10-15 08:32:21 +00:00
Outdated
Review
Copy Link

its not really to short, is just had a wrong length....

its not really to short, is just had a wrong length....
}
result := client.WithContext(ctx).Delete(&poolPost, "pool_id = ? AND post_id = ?", poolID, postID)

8
pkg/database/pool_reference.go
View File

@ -37,7 +37,7 @@ func CreatePoolReference(ctx context.Context, poolID models.PoolID, sourceID mod
}
if len(poolID) != 25 {
return models.PoolReference{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PoolIDToShort})
return models.PoolReference{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PoolIDIsWrongLength})
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-10-15 08:33:48 +00:00
Outdated
Review
Copy Link

its not really to short, is just had a wrong length....

its not really to short, is just had a wrong length....
}
if sourceID == "" {
@ -45,7 +45,7 @@ func CreatePoolReference(ctx context.Context, poolID models.PoolID, sourceID mod
}
if len(sourceID) != 25 {
return models.PoolReference{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.SourceIDToShort})
return models.PoolReference{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.SourceIDIsWrongLength})
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-10-15 08:33:56 +00:00
Outdated
Review
Copy Link

its not really to short, is just had a wrong length....

its not really to short, is just had a wrong length....
}
if url == "" {
@ -97,7 +97,7 @@ func DeletePoolReference(ctx context.Context, poolID models.PoolID, sourceID mod
}
if len(poolID) != 25 {
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PostIDToShort})
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PostIDIsWrongLength})
Alphyron commented 2024-10-15 08:34:27 +00:00
Outdated
Review
Copy Link

its not really to short, is just had a wrong length....

its not really to short, is just had a wrong length....
Alphyron commented 2024-10-15 08:49:56 +00:00
Outdated
Review
Copy Link

Please recheck this, you want to check if the length nis not 25!

Please recheck this, you want to check if the length nis not 25!
}
if sourceID == "" {
@ -105,7 +105,7 @@ func DeletePoolReference(ctx context.Context, poolID models.PoolID, sourceID mod
}
if len(sourceID) != 25 {
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.SourceIDToShort})
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.SourceIDIsWrongLength})
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-10-15 08:34:31 +00:00
Outdated
Review
Copy Link

its not really to short, is just had a wrong length....

its not really to short, is just had a wrong length....
}
result := client.WithContext(ctx).Delete(&poolReference, "pool_id = ? AND source_id = ?", poolID, sourceID)

2
pkg/database/post.go
View File

@ -191,7 +191,7 @@ func DeletePost(ctx context.Context, id models.PostID) error {
}
if len(id) != 25 {
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PostIDToShort})
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PostIDIsWrongLength})
}
result := client.WithContext(ctx).Delete(&userFavorite, "id = ?", id)

4
pkg/database/source.go
View File

@ -155,7 +155,7 @@ func GetSourceByID(ctx context.Context, id models.SourceID) (models.Source, erro
}
if len(id) != 25 {
return models.Source{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.SourceIDToShort})
return models.Source{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.SourceIDIsWrongLength})
}
result := client.WithContext(ctx).First(&source, "id = ?", id)
@ -231,7 +231,7 @@ func DeleteSource(ctx context.Context, id models.SourceID) error {
}
if len(id) != 25 {
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.SourceIDToShort})
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.SourceIDIsWrongLength})
}
result := client.WithContext(ctx).Delete(&source, id)

4
pkg/database/userSource.go
View File

@ -118,7 +118,7 @@ func GetUserSourceByID(ctx context.Context, id models.UserSourceID) (models.User
}
if len(id) != 25 {
return models.UserSource{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.UserSourceIDToShort})
return models.UserSource{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.UserSourceIsWrongLength})
}
result := client.WithContext(ctx).First(&user, "id = ?", id)
@ -157,7 +157,7 @@ func DeleteUserSource(ctx context.Context, id models.UserSourceID) error {
}
if len(id) != 25 {
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.UserSourceIDToShort})
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.UserSourceIsWrongLength})
}
result := client.WithContext(ctx).Delete(&user, id)

28
pkg/error/validation.go
View File

@ -3,13 +3,13 @@ package error
import "fmt"
const (
SourceListIsEmpty = "sourceList cannot be empty"
SourceIDIsEmpty = "SourceID cannot be empty"
SourceIDToShort = "sourceID needs to be 25 characters long"
SourceDomainIsEmpty = "source Domain cannot be empty"
SourceListIsEmpty = "sourceList cannot be empty"
SourceIDIsEmpty = "SourceID cannot be empty"
SourceIDIsWrongLength = "sourceID has the wrong length"
SourceDomainIsEmpty = "source Domain cannot be empty"
UserSourceIDIsEmpty = "userSourceID cannot be empty"
UserSourceIDToShort = "userSourceID needs to be 25 characters long"
UserSourceIDIsEmpty = "userSourceID cannot be empty"
UserSourceIsWrongLength = "userSourceID has the wrong length"
TagNameIsEmpty = "tagName cannot be empty"
TagTypeIsEmpty = "tagType cannot be empty"
@ -21,18 +21,18 @@ const (
TagGroupListIsEmpty = "tagGroupList cannot be empty"
TagGroupNameIsEmpty = "tagGroupName cannot be empty"
UserFavoriteListIsEmpty = "userFavoriteList cannot be empty"
UserFavoriteIDIsEmpty = "userFavoriteID cannot be empty"
UserFavoriteIDToShort = "userFavoriteID needs to be 25 characters long"
UserFavoriteListIsEmpty = "userFavoriteList cannot be empty"
UserFavoriteIDIsEmpty = "userFavoriteID cannot be empty"
UserFavoriteIsWrongLength = "userFavoriteID has the wrong length"
PostListIsEmpty = "userFavoriteList cannot be empty"
PostIDIsEmpty = "userFavoriteID cannot be empty"
PostIDToShort = "PostID needs to be 25 characters long"
PostListIsEmpty = "userFavoriteList cannot be empty"
PostIDIsEmpty = "userFavoriteID cannot be empty"
PostIDIsWrongLength = "PostID has the wrong length"
BatchSizeIsEmpty = "batchSize cannot be empty"
PoolIDIsEmpty = "PoolID cannot be empty"
PoolIDToShort = "PoolID needs to be 25 characters long"
PoolIDIsEmpty = "PoolID cannot be empty"
PoolIDIsWrongLength = "PoolID has the wrong length"
PoolURLIsEmpty = "PoolURL cannot be empty"
)