Anthrove/otter-space-sdk
5
0
Fork 0
Code Issues Pull Requests Actions Projects Releases 9 Activity

added pools #14

Merged
SoXX merged 16 commits from dev/pools into main 2024-10-15 09:03:46 +00:00
Conversation 0 Commits 16 Files Changed 20 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d753d32025 - Show all commits

4
pkg/database/pool_post.go
View File

@ -36,7 +36,7 @@ func CreatePoolPost(ctx context.Context, poolID models.PoolID, postID models.Pos
return models.PoolPost{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PoolIDIsEmpty})
}
if len(poolID) != 0 {
if len(poolID) != 25 {
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-10-15 08:55:42 +00:00
Outdated
Review
Copy Link

Please recheck this, you want to check if the length nis not 25!

Please recheck this, you want to check if the length nis not 25!
return models.PoolPost{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PoolIDIsWrongLength})
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-10-15 08:31:36 +00:00
Outdated
Review
Copy Link

its not really to short, is just had a wrong length....

its not really to short, is just had a wrong length....
Alphyron commented 2024-10-15 08:48:49 +00:00
Outdated
Review
Copy Link

Please recheck this, you want to check if the length nis not 25!

Please recheck this, you want to check if the length nis not 25!
}
@ -92,7 +92,7 @@ func DeletePoolPost(ctx context.Context, poolID models.PoolID, postID models.Pos
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PoolIDIsEmpty})
Alphyron marked this conversation as resolved
Alphyron commented 2024-10-15 08:32:56 +00:00
Review
Copy Link

Either you use len(poolID) == 0 like in pool.go or you use this method in pool.go. But not both!

Either you use len(poolID) == 0 like in pool.go or you use this method in pool.go. But not both!
}
if len(poolID) != 0 {
if len(poolID) != 25 {
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-10-15 08:55:48 +00:00
Outdated
Review
Copy Link

Please recheck this, you want to check if the length nis not 25!

Please recheck this, you want to check if the length nis not 25!
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.PoolIDIsWrongLength})
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-10-15 08:32:17 +00:00
Outdated
Review
Copy Link

its not really to short, is just had a wrong length....

its not really to short, is just had a wrong length....
Alphyron commented 2024-10-15 08:49:07 +00:00
Outdated
Review
Copy Link

Please recheck this, you want to check if the length nis not 25!

Please recheck this, you want to check if the length nis not 25!
}