From 130f6928fca0dc64fcc1f5799fb505d637d5a3ce Mon Sep 17 00:00:00 2001 From: Alphyron Date: Tue, 27 Aug 2024 07:32:24 +0200 Subject: [PATCH] refactor: move otlp to custom file out of the scope from plug instance --- pkg/plug/otlp.go | 31 +++++++++++++++++++++++++++++++ pkg/plug/server.go | 24 ------------------------ 2 files changed, 31 insertions(+), 24 deletions(-) create mode 100644 pkg/plug/otlp.go diff --git a/pkg/plug/otlp.go b/pkg/plug/otlp.go new file mode 100644 index 0000000..296b9e2 --- /dev/null +++ b/pkg/plug/otlp.go @@ -0,0 +1,31 @@ +package plug + +import ( + "context" + "git.anthrove.art/Anthrove/plug-sdk/v3/pkg/telemetry" + log "github.com/sirupsen/logrus" + "go.opentelemetry.io/otel/codes" +) + +func SetupOpenTelemtry(ctx context.Context, serviceName string) error { + ctx, span := tracer.Start(ctx, "SetupOpenTelemtry") + defer span.End() + + err := telemetry.SetupMeterProvider(serviceName) + if err != nil { + span.RecordError(err) + span.SetStatus(codes.Error, err.Error()) + log.WithContext(ctx).WithError(err).Error("Failed to setup meter provider") + return err + } + + err = telemetry.SetupTraceProvider(ctx, serviceName) + if err != nil { + span.RecordError(err) + span.SetStatus(codes.Error, err.Error()) + log.WithContext(ctx).WithError(err).Error("Failed to setup trace provider") + return err + } + + return nil +} diff --git a/pkg/plug/server.go b/pkg/plug/server.go index d410626..e813f71 100644 --- a/pkg/plug/server.go +++ b/pkg/plug/server.go @@ -8,7 +8,6 @@ import ( "git.anthrove.art/Anthrove/otter-space-sdk/v3/pkg/database" "git.anthrove.art/Anthrove/otter-space-sdk/v3/pkg/models" pb "git.anthrove.art/Anthrove/plug-sdk/v3/pkg/grpc" - "git.anthrove.art/Anthrove/plug-sdk/v3/pkg/telemetry" log "github.com/sirupsen/logrus" "go.opentelemetry.io/otel" "go.opentelemetry.io/otel/attribute" @@ -158,26 +157,3 @@ func (p *Plug) GetMessageExecution(function GetMessageExecution) { p.getMessageExecution = function span.AddEvent("Get message execution function set") } - -func (p Plug) SetupOpenTelemtry() error { - ctx, span := tracer.Start(p.ctx, "SetupOpenTelemtry") - defer span.End() - - err := telemetry.SetupMeterProvider(p.plugName) - if err != nil { - span.RecordError(err) - span.SetStatus(codes.Error, err.Error()) - log.WithContext(ctx).WithError(err).Error("Failed to setup meter provider") - return err - } - - err = telemetry.SetupTraceProvider(ctx, p.plugName) - if err != nil { - span.RecordError(err) - span.SetStatus(codes.Error, err.Error()) - log.WithContext(ctx).WithError(err).Error("Failed to setup trace provider") - return err - } - - return nil -}