Anthrove/plug-sdk
4
0
Fork 0
Code Issues Pull Requests Actions Projects Releases 6 Activity

fix: context creation to use request context in TaskStart method
All checks were successful
Gitea Build Check / Build (pull_request) Successful in 44s
Details

Browse Source
This commit is contained in:
David Janowski 2024-08-26 16:38:14 +02:00
parent 0e57346f52
commit 6b91b4ef09
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/plug/grpc.go
View File

@ -60,11 +60,11 @@ func (s *server) TaskStart(ctx context.Context, creation *gRPC.PlugTaskCreation)
// gRPC closes the context after the call ended. So the whole scrapping stopped without waiting // gRPC closes the context after the call ended. So the whole scrapping stopped without waiting
// by using this method we assign a new context to each new request we get. // by using this method we assign a new context to each new request we get.
// This can be used for example to close the context with the given id // This can be used for example to close the context with the given id
taskCtx, cancel := context.WithCancel(context.Background()) taskCtx, cancel := context.WithCancel(ctx)
s.ctx[id] = cancel s.ctx[id] = cancel
span.AddEvent("Created new context for task", trace.WithAttributes(attribute.String("task_id", id))) span.AddEvent("Created new context for task", trace.WithAttributes(attribute.String("task_id", id)))
log.WithContext(ctx).WithFields(log.Fields{ log.WithContext(taskCtx).WithFields(log.Fields{
"task_id": id, "task_id": id,
"user_source_id": creation.UserSourceId, "user_source_id": creation.UserSourceId,
}).Info("Starting task") }).Info("Starting task")