Anthrove/plug-sdk
4
0
Fork 0
Code Issues Pull Requests Actions Projects Releases 6 Activity

dev/extending-sdk-with-missing-grpc-functions #8

Merged
SoXX merged 5 commits from dev/extending-sdk-with-missing-grpc-functions into main 2024-09-04 12:57:14 +00:00
Conversation 0 Commits 5 Files Changed 1 +4 -4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 38cecba455 - Show all commits

8
pkg/plug/grpc.go
View File

@ -167,7 +167,7 @@ func (s *server) GetUserMessages(ctx context.Context, message *gRPC.GetMessagesR
if err != nil { if err != nil {
span.RecordError(err) span.RecordError(err)
span.SetStatus(codes.Error, err.Error()) span.SetStatus(codes.Error, err.Error())
log.WithContext(ctx).WithError(err).Error("getting userSource") log.WithContext(ctx).WithError(err).Error("Getting userSource")
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-09-04 12:55:49 +00:00
Outdated
Review
Copy Link

Satz fängt groß an!

Satz fängt groß an!
return nil, err return nil, err
} }
@ -175,7 +175,7 @@ func (s *server) GetUserMessages(ctx context.Context, message *gRPC.GetMessagesR
if err != nil { if err != nil {
span.RecordError(err) span.RecordError(err)
span.SetStatus(codes.Error, err.Error()) span.SetStatus(codes.Error, err.Error())
log.WithContext(ctx).WithError(err).Error("execution function") log.WithContext(ctx).WithError(err).Error("Execution function")
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-09-04 12:55:53 +00:00
Outdated
Review
Copy Link

Satz fängt groß an!

Satz fängt groß an!
return nil, err return nil, err
} }
@ -221,7 +221,7 @@ func (s *server) SendMessage(ctx context.Context, message *gRPC.SendMessageReque
err := s.sendMessageExecution(ctx, userSource, message.Message) err := s.sendMessageExecution(ctx, userSource, message.Message)
if err != nil { if err != nil {
log.WithContext(ctx).WithError(err).Error("sending message executiom") log.WithContext(ctx).WithError(err).Error("Sending message execution")
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-09-04 12:56:00 +00:00
Outdated
Review
Copy Link

Satz fängt groß an!

Satz fängt groß an!
span.RecordError(err) span.RecordError(err)
span.SetStatus(codes.Error, err.Error()) span.SetStatus(codes.Error, err.Error())
@ -244,7 +244,7 @@ func (s *server) Ping(ctx context.Context, ping *gRPC.PingRequest) (*gRPC.PongRe
"messsage": ping.Message, "messsage": ping.Message,
"timestamp": ping.Timestamp, "timestamp": ping.Timestamp,
} }
log.WithContext(ctx).WithFields(fields).Trace("got pinged") log.WithContext(ctx).WithFields(fields).Trace("Got pinged")
Alphyron marked this conversation as resolved Outdated
Alphyron commented 2024-09-04 12:56:04 +00:00
Outdated
Review
Copy Link

Satz fängt groß an!

Satz fängt groß an!
return &pong, nil return &pong, nil
} }