Anthrove/otter-space-sdk
5
0
Fork 0
Code Issues 3 Pull Requests Actions Projects Releases 13 Activity

Add Scrape History #15

Merged
SoXX merged 8 commits from dev/scrape-history into main 2024-10-15 10:46:41 +00:00
Conversation 3 Commits 8 Files Changed 7 +639
SoXX commented 2024-10-15 09:24:51 +00:00
Owner
Copy Link
No description provided.
SoXX added 2 commits 2024-10-15 09:24:51 +00:00 
- added migration
feat(database): added model
All checks were successful
Gitea Build Check / Build (pull_request) Successful in 3m4s
Details
4312cbdff5 
- added model
- added test for model
SoXX added 2 commits 2024-10-15 10:25:49 +00:00 
- added Create
- added Get
- added Update
- added Delete
feat(database): added tests
Some checks failed
Gitea Build Check / Build (pull_request) Failing after 3m0s
Details
a6d95067fe 
- added Create
- added Get
- added Update
- added Delete
SoXX requested review from Alphyron 2024-10-15 10:26:05 +00:00
SoXX changed title from WIP: Add Scrape History to Add Scrape History 2024-10-15 10:27:54 +00:00
SoXX added 1 commit 2024-10-15 10:28:58 +00:00
fix(database): migration
Some checks failed
Gitea Build Check / Build (pull_request) Failing after 2m54s
Details
59f404883e 
- primary key is now first in position
Alphyron requested changes 2024-10-15 10:32:24 +00:00
Dismissed
pkg/database/scrape_history.go Outdated
@ -0,0 +32,4 @@
return models.ScrapeHistory{}, utils.HandleError(ctx, span, localLogger, &otterError.Database{Reason: otterError.DatabaseIsNotConnected})
}
result := client.WithContext(ctx).Create(&scrapeHistory)
Alphyron commented 2024-10-15 10:29:30 +00:00
Owner
Copy Link

keine ID validierung / verifizierung?

keine ID validierung / verifizierung?
Alphyron marked this conversation as resolved
pkg/database/scrape_history.go
@ -0,0 +68,4 @@
return models.ScrapeHistory{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.ScrapeTaskIDIsEmpty})
}
result := client.WithContext(ctx).First(&post, "scrape_task_id = ?", id)
Alphyron commented 2024-10-15 10:29:55 +00:00
Owner
Copy Link

ID wrong length check is missing

ID wrong length check is missing
Alphyron marked this conversation as resolved
pkg/database/scrape_history.go
@ -0,0 +107,4 @@
if len(scrapeHistory.ScrapeTaskID) == 0 {
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.ScrapeTaskIDIsEmpty})
}
Alphyron commented 2024-10-15 10:31:44 +00:00
Owner
Copy Link

ID wrong length check is missing

ID wrong length check is missing
Alphyron marked this conversation as resolved
pkg/database/scrape_history.go
@ -0,0 +152,4 @@
if len(id) == 0 {
return utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.ScrapeTaskIDIsEmpty})
}
Alphyron commented 2024-10-15 10:31:53 +00:00
Owner
Copy Link

ID wrong length check is missing

ID wrong length check is missing
Alphyron marked this conversation as resolved
SoXX added 1 commit 2024-10-15 10:37:05 +00:00
feat(database): validation
Some checks failed
Gitea Build Check / Build (pull_request) Failing after 3m0s
Details
f70879cf8d 
- added more validation for IDsi
SoXX added 1 commit 2024-10-15 10:41:09 +00:00
feat(database): tests
All checks were successful
Gitea Build Check / Build (pull_request) Successful in 3m18s
Details
0f1e6c6aaa 
- now the test against 25 char id length
Alphyron requested changes 2024-10-15 10:43:12 +00:00
Dismissed
pkg/database/scrape_history.go
@ -0,0 +39,4 @@
if len(scrapeHistory.ScrapeTaskID) != 25 {
return models.ScrapeHistory{}, utils.HandleError(ctx, span, localLogger, &otterError.EntityValidationFailed{Reason: otterError.ScrapeTaskIDIsWrongLength})
}
Alphyron commented 2024-10-15 10:42:29 +00:00
Owner
Copy Link

UserSourceID validation is missing

UserSourceID validation is missing
Alphyron marked this conversation as resolved
SoXX added 1 commit 2024-10-15 10:45:56 +00:00
feat(database): validation
All checks were successful
Gitea Build Check / Build (pull_request) Successful in 3m21s
Details
Gitea Build Check / Build (push) Successful in 3m20s
Details
ef31399ab6 
- check for user source
Alphyron approved these changes 2024-10-15 10:46:17 +00:00
SoXX merged commit ef31399ab6 into main 2024-10-15 10:46:41 +00:00
SoXX deleted branch dev/scrape-history 2024-10-15 10:46:41 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Alphyron
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anthrove/otter-space-sdk#15
No description provided.
Delete Branch "dev/scrape-history"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?