Anthrove/otter-space-sdk
5
0
Fork 0
Code Issues 3 Pull Requests Actions Projects Releases 13 Activity

refactor: unified migrations and Tag* ID Changes #29

Merged
SoXX merged 5 commits from feature/v6 into main 2025-01-28 13:18:02 +00:00
Conversation 2 Commits 5 Files Changed 47 +473 -468
SoXX commented 2025-01-28 12:29:02 +00:00
Owner
Copy Link
  • unified the migrations
  • added new IDs for Tag, TagAlias, TagGroup
  • changed relevant functions to use the given IDs

BREAKING-CHANGE: Database needs to be cleared or migrated. Not compatible with Database v5

- unified the migrations - added new IDs for Tag, TagAlias, TagGroup - changed relevant functions to use the given IDs **BREAKING-CHANGE**: Database needs to be cleared or migrated. Not compatible with Database v5
SoXX added 1 commit 2025-01-28 12:29:02 +00:00
refactor: unified migrations and Tag* ID Changes
All checks were successful
Gitea Build Check / Build (pull_request) Successful in 3m8s
Details
6f814e5b21 
- unified the migrations
- added new IDs for Tag, TagAlias, TagGroup
- changed relevant functions to use the given IDs

BREAKING-CHANGE: Database needs to be cleared or migrated. Not compatible with Database v5
SoXX requested review from Alphyron 2025-01-28 12:29:03 +00:00
SoXX added 1 commit 2025-01-28 12:41:22 +00:00
feat(database): add ON DELETE CASCADE constraints
All checks were successful
Gitea Build Check / Build (pull_request) Successful in 3m5s
Details
ecbf139a9b
Alphyron requested changes 2025-01-28 12:54:12 +00:00
Dismissed
pkg/models/tag.go Outdated
@ -19,1 +19,3 @@
TagID TagName `json:"tag_id"`
ID TagAliasID `json:"id" gorm:"primaryKey"`
Name TagAliasName `json:"name"`
TagID TagID `json:"tag_name"`
Alphyron commented 2025-01-28 12:36:30 +00:00
Owner
Copy Link

tag id not tag name in json

tag id not tag name in json
Alphyron marked this conversation as resolved
SoXX added 1 commit 2025-01-28 12:59:51 +00:00
feat: add hard delete option to delete functions
Some checks failed
Gitea Build Check / Build (pull_request) Failing after 31s
Details
c9b0c71bef
SoXX added 2 commits 2025-01-28 13:05:57 +00:00
fix: incorrect struct field names for TagAlias and TagGroup
All checks were successful
Gitea Build Check / Build (pull_request) Successful in 2m56s
Details
Gitea Build Check / Build (push) Successful in 2m56s
Details
6f7c89a76b
Alphyron approved these changes 2025-01-28 13:11:12 +00:00
SoXX merged commit 6f7c89a76b into main 2025-01-28 13:18:02 +00:00
SoXX deleted branch feature/v6 2025-01-28 13:18:02 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Alphyron
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Anthrove/otter-space-sdk#29
No description provided.
Delete Branch "feature/v6"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?